Add atomic operation functions to improve code compatibility with Delphi XE2#49
Open
delphilite wants to merge 7 commits intopleriche:masterfrom
Open
Add atomic operation functions to improve code compatibility with Delphi XE2#49delphilite wants to merge 7 commits intopleriche:masterfrom
delphilite wants to merge 7 commits intopleriche:masterfrom
Conversation
Owner
|
Hi, Thank you for the kind words and the pull request. The decision regarding which versions to support in FastMM5 was not an easy one. The fact that XE2 does not have the atomic operations played a part, but I recall that there were also compiler bugs. I can't remember the details, but the fact that you got it working with XE2 suggests they probably didn't end up being an issue. I don't currently have XE2 installed, but I'll put testing the XE2 support on my to-do list. In the meantime I'll leave the pull request open so anyone who wants XE2 support can merge it themselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Pierre le Riche, I have always been a big fan of FastMM4, thank you for your work over the years.
I noticed that FastMM5 cannot be compiled in XE2 environment. With reference to some other code, I have completed the missing atomic operations and modified the compatibility of the compilation instructions.
The modifications have passed simple tests under Delphi XE2 and 12. I hope this PR can be accepted.